Lookup infra objects for global params#485
Open
day0hero wants to merge 3 commits intovalidatedpatterns:mainfrom
Open
Lookup infra objects for global params#485day0hero wants to merge 3 commits intovalidatedpatterns:mainfrom
day0hero wants to merge 3 commits intovalidatedpatterns:mainfrom
Conversation
- infra.Status.ControlPlaneTopology is how we can programmatically determine the type of cluster we're on. - External=HyperShift - SingleReplica/HighlyAvailable-Traditional/Normal - infra.Status.APIServerURL is how we can programmatically determine the api address of the cluster. - In the past we have gotten away with this because we could use the clusterDomain but HyperShift uses the DNS name of the ELB it provisions for the hosted cluster. - In addition to these changes, added a sample pattern crd for testing the operator.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: day0hero The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mbaldessari
reviewed
Dec 11, 2025
hack/operator-build-deploy.sh
Outdated
Contributor
There was a problem hiding this comment.
Don't delete this one, we love it ;)
mbaldessari
reviewed
Dec 11, 2025
|
|
||
| output.Status.ClusterPlatform = string(clusterInfra.Spec.PlatformSpec.Type) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Just look up the two new fields here, add them to the status and then place them in the values parameters. I think there is no need to add all that code in other places
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
infra.Status.ControlPlaneTopology is how we can programmatically
determine the type of cluster we're on.
External=HyperShift
SingleReplica/HighlyAvailable-Traditional/Normal
infra.Status.APIServerURL is how we can programmatically determine the
api address of the cluster.
In the past we have gotten away with this because we could use the
clusterDomain but HyperShift uses the DNS name of the ELB it
provisions for the hosted cluster.
In addition to these changes, added a sample pattern crd for testing
the operator.